-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PG macro library (with latex-image-preamble support) #1478
Conversation
Stand by. Just realized I need to look into where the regular |
OK. I put a new variable in common, Later if something like |
Got pulled away for life things. I'll holler when this is really ready for you to look at. |
OK, I force pushed after working in the remaining to-dos that occurred to me late. It's still the case that the first commit here is the main one. And ready for your examination. (And will need a schema rebuild once ready.) |
First pass looks good. Some nits, as usual. Another meeting before Drop-In so details may need to wait a bit. |
Do you have a stance on |
Some nits addressed in a force push, including proper use of |
Working off previous version, not latest.
Sorry for all the nits - there's a lot going on here. I'll merge if you force-push again. Let's put schema changes on their own PR from here on out, prefixed with |
It points to a description list item, so previously, was getting a PTX warning message when building because it has no number. I was trying to clean up the build. Should I change it back? That's separate from the real work here, so commenting separately. I'll work on that soon. It's nice if this can be resolved before next week, but not necessary. It's close enough that I would feel good about making edits to ORCCA and APEX based on this even if it's not completely settled. |
Thanks, that explains it! Keep it!
…On 5/22/21 9:14 AM, Alex Jordan wrote:
I'd rather not xref by title, since it is worthless in print. (In
offline-mathjax.html) Was there a specific reason for this one?
It points to a description list item, so previously, was getting a PTX warning
message when building because it has no number. I was trying to clean up the
build. Should I change it back?
That's separate from the real work here, so commenting separately. I'll work on
that soon. It's nice if this can be resolved before next week, but not
necessary. It's close enough that I would feel good about making edits to ORCCA
and APEX based on this even if it's not completely settled.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1478 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOLM4VDERIUGUHYATZRSODTO7J4XANCNFSM45H7FSPQ>.
|
Some questions with the first few items here. Then reports of nits cleared.
Will we enforce (in schema) that there is only one In any case, I will make the comment more clear if you can give me guidance about those questions I have.
Sounds like you are saying this is at least OK for now, but maybe warrants more thought in the long run?
Later, once I understand things better, I would like to make it so
If I remove
Got it. Added
Got it.
Got it. |
Force pushed. Still up to any changes to make in that comment about having multiple |
I think the schema could do this, but it'd be messy, and might be the sort of attribute-dependent thing which does not show up in the schema browser after translation. So perhaps not really worth it.
Yes, let's not delay this for this.
They can stay while you have a plan. Oscar Steven CLI may build on these routines, so stability is good.
If you want. ;-) I know about it, and I know it will cause failure. Just be sure to add the new |
I changed |
Ready to go, then? (I still haven't done any testing, but maybe late tonight I'll be in the mood.) |
I think it's ready. At least, it passed my testing and I think all the issues raised in this thread are handled. |
OK, merged and pushed. Website rebuilding now. We need a better solution to
|
Just checking something. Did you "manage images" and put the image files on the web server? Simple test: if you are there and you see the "special character" graph where it should not be, then you "make interactive" does it become the right image? |
At the moment, I cannot get anything at https://pretextbook.org/ to load, so I can't look closely at it. Any reason https://pretextbook.org/ would be down right now? |
Try again, you might have hit rsync operation. |
Just checked website HTML version. Neither polynomial nor special character image appears when knowl opens. Problem persists with a page refresh. "Make Interactive" on polynomial will then display plot. Special characters does not have answers, so can't go interactive. Do you see the same? |
I don't have image management working yet. :-( Send instructions? Missing images from before was next on my list. |
I was on my school's VPN. Got off, and now things work. Would not be surprised if there is some issue there today that caused trouble with loading pretexbook.org. What I mean is not new "image management" stuff. I mean old school, where publisher is responsible to move image files to a place where the web page can find them. If I go to: https://pretextbook.org/examples/webwork/sample-chapter/html/section-9.html Locally, something similar could have happened where there were image files where they needed to be, but they had not been updated, and |
I'm not certain I know whatt "where they needed to be" means. Talk to me like I'm a 5-year-old. ;-) And I'll work through it. |
If you go here: Then open Checkpoint 9.1, at this point everything is static. Don't hit "Make interactive". There is no image there (just the alt text description). It is looking for the image on your server at location: Where is |
OK, thanks. Now second on my list (I'm looking at Python imports for a bit). |
Post on -dev about schema commits. Just to keep you hopping! |
Look now.
My build script has evolved into a monster. I drag my feet when it comes to changes. ;-) But that was what I needed - thanks - should be good now. I think we are done with this one now! |
Wrong. ;-) I added the |
Second commit here: small things I noticed should be updated while working on the doc.
Third commit: changes to the debugging messages when building ww-reps.
First commit is the main one.
image/latex-image[@syntax = 'PGtikz']
gets an extra line that tries to add the latex image preamble content from a macro file.pretex -c pg-macros source.ptx
and then upload it to the host course. This must be done before processing the webwork exercises. I put this file for the sample chapter up on the AIM host course already, and also committed it into the sample chapter folder.