-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Youtube playlist #947
Youtube playlist #947
Conversation
Looks good. Let's put "playlist" into |
XSLT in place for HTML. Do you want to take a look and comment? |
Figures 16.12 and 16.13 here, if you'd like to peek at output: |
Looks good. Didn't require too much surgery, no? Right now, if an author uses a single-video ID and includes a stray space before or after, that one video will get packaged as a 1-video playlist, no? How about a plain |
I can do what you are suggesting. It feels |
Oops |
I was going to say, it feels off balance in one way to correct the author's stray space, but not a stray comma if they left one. But it sounds easy to do. |
Just reading commits (not the cumulative effect, locally), but I think I have a handle on current state. Looks fine. But see if you like this better. Basically get commas out of the way early and add back last.
Sorry for the delay, startups have been keeping me busy. |
OK, I was avoiding introducing a variable The stylesheet could be cleaner if the URL were allowed to be built with an ampersand on the first option. Like |
4781836
to
7d7a2a3
Compare
LaTeX YT playlist is now here for your first impressions. I haven't actually tested so maybe there is a typo or something. Moving on to the script to get it to scrape first image from a list-defined playlist. Will do a complete test after that. |
As happens, I immediately see issue. Please disregard until I signal the whole thing is tested and ready for review. |
No firm opinion.
But am wondering, when will the reader see this URL and be chopping out options?
In the raw HTML? Not checking anything carefully, just presuming the reader
sees an embedded video *within some page* in their browser and so does not have
easy access to the URL?
…On 09/05/2018 02:07 PM, Alex Jordan wrote:
OK, I was avoiding introducing a variable |$youtube|. But happy to do that.
The stylesheet could be cleaner if the URL were allowed to be built with an
ampersand on the first option. Like
|https://www.youtube.com/embed?&listType=playlist| instead of
|https://www.youtube.com/embed?listType=playlist|. The |?&| appeals to me
because on those rare occasions when it matters, it is easier to cut and paste
the options out of a URL. The only down side is that the simpler |?| looks more
"human-written". But both function. Do you have an opinion on this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#947 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABy2cj49Z652j7rSik5ntVK7D2qD-YILks5uYDz3gaJpZM4WM_Ta>.
|
A `reader` doesn't. An `instructor` may pop into the browser to grab the
url to duplicate in some LMS.
I do this kind of thing to change seeds in ww problems for testing, so it's
on my mind. Ignoring this, it's a question of cleaner XSLT versus
"prettier" output.
…On Wed, Sep 5, 2018 at 3:40 PM, Rob Beezer ***@***.***> wrote:
No firm opinion.
But am wondering, when will the reader see this URL and be chopping out
options?
In the raw HTML? Not checking anything carefully, just presuming the
reader
sees an embedded video *within some page* in their browser and so does not
have
easy access to the URL?
On 09/05/2018 02:07 PM, Alex Jordan wrote:
> OK, I was avoiding introducing a variable |$youtube|. But happy to do
that.
>
> The stylesheet could be cleaner if the URL were allowed to be built with
an
> ampersand on the first option. Like
> |https://www.youtube.com/embed?&listType=playlist| instead of
> |https://www.youtube.com/embed?listType=playlist|. The |?&| appeals
to me
> because on those rare occasions when it matters, it is easier to cut and
paste
> the options out of a URL. The only down side is that the simpler |?|
looks more
> "human-written". But both function. Do you have an opinion on this?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#947 (comment)>,
or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/
ABy2cj49Z652j7rSik5ntVK7D2qD-YILks5uYDz3gaJpZM4WM_Ta>.
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#947 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEg3ABfOa_Wtxa6XL46H0xx_EFYpddbNks5uYFLLgaJpZM4WM_Ta>
.
--
Alex Jordan
Mathematics Instructor
Portland Community College
|
OK, tested and ready for review. Perhaps in this order:
|
On 09/05/2018 04:21 PM, Alex Jordan wrote:
4.
Ultimately this will make a thumbnail for the "enumerated" playlist. Should
I commit that to the repo like all other youtube thumbnail images for the
sample article?
Yes, please include the thumbnails. We want newcomers to build the sample
article without running the "mbx" script.
More later.
|
Thumbnail committed. And a bunch of cleanup I somehow missed on my last pass. |
I need to do more work on static versions of interactive portions, so I'll think more about captions then. |
Nice work, this is a great enhancement. Corrected one small typo. Otherwise, repackaged as six topical commits, each with your name on it. Feel free to run your own advertisement on Thanks! What's next? |
Starting with this to see if anything about the documentation raises flags for you. I'll continue to commit parts to this branch and you could package it into one commit when it's all done.
There is some magic distinction between YT users and channels that I cannot fully grok. Sometimes I can get a channel embedded, sometimes not. Sometimes a user's uploads, sometimes not. So I am bailing on that kind of extension for now. Playlists only.