Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP-3 Fields with even number of values is not calculating length properly. #18

Closed
rbheemana opened this issue Oct 21, 2016 · 4 comments
Assignees

Comments

@rbheemana
Copy link
Owner

The number of bytes a PIC S9(m) COMP-3 takes is (m+1)/2. So the number of bytes used for 9(2) and a 9(3) are the same. The last nibble of the byte will contain the "sign" of the value. Mainframes can implicitly deal with this but you have to explicitly change the value for the serde to handle it.

SERDE should create length as 2 for S9(2) COMP-3. Currently it is creating a length of 1.

@datawarlock
Copy link
Collaborator

Hey Ram - We (myself and a team member) have made some changes to the serde. I have submitted a pull request for your review.

@tejasbharambe
Copy link

tejasbharambe commented Feb 24, 2017 via email

@rbheemana
Copy link
Owner Author

rbheemana commented Mar 8, 2017

@datawarlock @josephlim75 @ankravch @tejasbharambe I have updated the code to resolve this issue in the branch Issue#18. I have also added test cases. Would you be able to download compile and test the code if it works as expected. If u could confirm the changes looks good, I can merge the Issue#18 branch to Main branch. Thanks in advance for all the help.

@rbheemana
Copy link
Owner Author

Code is merged closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants