Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidelines for using Prettier #87

Open
1 task
adityaraute opened this issue Jan 11, 2024 · 8 comments
Open
1 task

Add guidelines for using Prettier #87

adityaraute opened this issue Jan 11, 2024 · 8 comments

Comments

@adityaraute
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently Prettier is not being used by all contributors.

Describe the solution you'd like
Atleast a guide describing the expected actions from each contributor. Would be happy to know any other tasks.

  • Would you like to work on this?
@adityaraute
Copy link
Collaborator Author

@agriyakhetarpal
@b-mendoza
I've created the issue as mentioned in #72
Would like to finalise the next steps for the same.

@agriyakhetarpal
Copy link
Collaborator

I think the best way to get contributors to use Prettier in general is to add instructions about how to use pre-commit. Once they install it and other hooks at .git/hooks/, they will run before the author tries to commit any staged files locally. The next step would be to get https://pre-commit.ci as we had discussed previously and add a pre-commit configuration file to the repository.

These details can then be integrated into a small yet sufficient Contributing guide by @b-mendoza in a follow-up PR to #72, as they had mentioned.

@b-mendoza
Copy link
Contributor

I will take some time this afternoon to take a look at this and post some thoughs 🫡

@adityaraute
Copy link
Collaborator Author

Perfect, thanks

@adityaraute
Copy link
Collaborator Author

Hi @b-mendoza just wanna know if I can assign this issue to you.

@adityaraute
Copy link
Collaborator Author

I will take some time this afternoon to take a look at this and post some thoughs 🫡

Hi,
Did you get a chance to review this?

@adityaraute
Copy link
Collaborator Author

I will take some time this afternoon to take a look at this and post some thoughs 🫡

Waiting for you to update us on this issue...

@adityaraute
Copy link
Collaborator Author

@b-mendoza If no update is received by the end of May, I will have to unassign you from this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants