Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbus 1.2.23 no longer supports GHC 8 #56

Closed
elldritch opened this issue Feb 27, 2022 · 5 comments
Closed

dbus 1.2.23 no longer supports GHC 8 #56

elldritch opened this issue Feb 27, 2022 · 5 comments

Comments

@elldritch
Copy link

This is caused by #55 bumping the version of Template Haskell. See also: build failures on Hackage.

I think the right solution is that either the version range on template-haskell needs to be loosened, or the supported versions of base need to be tightened to exclude older GHCs.

@rblaze
Copy link
Owner

rblaze commented Mar 4, 2022

template-haskell had a non-backward-compatible change, so the code wouldn't work with both new and old versions anymore. Does hackage use some base-based heuristics to detect GHC versions, ignoring all other bundled packages? There is no technical reason to tighten base bound but I can do it so that docs will be built.

@elldritch
Copy link
Author

I'm not sure, but my guess is yes since I've seen other packages that only support newer versions of GHC that specified base constraints and whose documentation properly built.

I think there's also a manual process for uploading documentation, although I can't remember exactly how it works off the top of my head.

@rblaze
Copy link
Owner

rblaze commented Mar 7, 2022

Released 1.2.24 with base >= 4.16

@rblaze rblaze closed this as completed Mar 7, 2022
@elldritch
Copy link
Author

Hmm, it looks like docs are still failing to build: https://hackage.haskell.org/package/dbus-1.2.24/reports/1. I'm not sure what's going on here or how to convince Hackage to build these docs - AFAICT it seems to be trying to build docs on a machine that's not running a supported version of GHC.

@dminuoso
Copy link

I find it sad that support for older GHC was dropped this way. How isolated is the backwards breaking change? Couldn't we simply use CPP to support older versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants