Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversion script 'ddl2cpp' does not support negative integer values #54

Closed
mitsutaka-takeda opened this issue Oct 6, 2015 · 4 comments

Comments

@mitsutaka-takeda
Copy link

When SQL include a negative integer value, ddl2cpp failed to convert the SQL.

CREATE TABLE TEST (
  id varchar(255) PRIMARY KEY,
  num integer DEFAULT -1
) ENGINE=InnoDB DEFAULT CHARSET=utf8

I think we need to add something like this to support negative numbers

negativeSign = Literal('-')
ddlNum     = Combine(Optional(negativeSign) + Word(nums + "."))
@rbock
Copy link
Owner

rbock commented Oct 6, 2015

Sounds good!

If you stumble over more things like this, could you make the changes in a fork and submit a pull request?

@mitsutaka-takeda
Copy link
Author

Sure! I'will.

@rbock
Copy link
Owner

rbock commented Dec 23, 2015

Fixed that in develop.

@rbock
Copy link
Owner

rbock commented Dec 29, 2015

Fixed in release 0.35

@rbock rbock closed this as completed Dec 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants