removed circular requires

[justinfreitag-zz]

I've gone through lib and test to remove the circular requires that center around ffi.js. My reason for doing this was to get the code (including libffi) working as a native module.

[TooTallNate]

Cool thanks, I've been meaning to do that. Looks mostly good, except you're changing the public api a lot, which is bad and unnecessary. I'll address some of them inline, but also, all the changes to test should be reverted, since that also should only test the public API.

My reason for doing this was to get the code (including libffi) working as a native module.

What does that mean exactly? node-ffi is a native module so I'm confused.

[TooTallNate]

Why did you change the name of this file? It's the entry point to the module as described in the package.json, so with it renamed the entry point is missing.

[justinfreitag-zz]

by 'native module' I meant 'core native', adding libffi as a dependency on core -- its part of a personal project. i'll have a go at restoring the public interface now (essentially ffi.js) and revert the tests.

[justinfreitag-zz]

restored the public api and reverted tests.

[TooTallNate]

Instead of defining this twice (here and in ffi.js), export it here as Library.EXT = EXT, and then re-export it in ffi.js as ffi.LIB_EXT = ffi.Library.EXT.

[TooTallNate]

Very good man a couple more things and then it looks great. Also, what's with that test/.callback.js.swp file?

[justinfreitag-zz]

my bad, I wrongly assumed there was a friendly .gitignore file in the repo. it's cleaned up now together with the duplicate LIB_EXT definitions and type.js comments

[TooTallNate]

Thanks @justinfreitag, merged in 0a556e9.