Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "Group Common Decliration Feature" going out live, breaking compilation #34

Closed
brookscom4580 opened this issue Nov 6, 2018 · 3 comments

Comments

@brookscom4580
Copy link

Hello, The "new feature" released in version 3.1.0 went out live instead of dark (for some reason) and is generated erroneously unnested selectors.

Here's a gist for comparison:
https://gist.github.com/brookscom4580/916e012af880e06745b1aaaf234d4fa9

In this gist I've added 4 "files":

  • prepurge.css is what we're sending into css-purge
  • 3.0.14_post.css is what has been being compiled before version 3.1.0
  • 3.1.0_post.css is what we're seeing get compiled with version 3.1.0
  • oddity.css calls out the compile issue

I'm sure there is a way to turn off this new feature but given that it went out live it created a quick path to a production issue for us. I expect other people might see the same types of issue as well. Maybe the feature should be set to dark / false by default?

@AndrewEQ
Copy link
Contributor

AndrewEQ commented Nov 6, 2018

Thanks for the feedback, you're right, maybe was a little too ambitious with this release, will turn it off by default.

@AndrewEQ AndrewEQ closed this as completed Nov 6, 2018
@brookscom4580
Copy link
Author

Much appreciated!

@AndrewEQ
Copy link
Contributor

AndrewEQ commented Nov 6, 2018

Made the update, lemme know if its still giving issues, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants