Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Router API #16

Closed
wants to merge 4 commits into from
Closed

Message Router API #16

wants to merge 4 commits into from

Conversation

nikita-petko
Copy link
Contributor

This API only consists of /v1/router/signalr, and will only support Studio messages (I haven't found out what the main channel/main accessKey is for open grid servers)

@jmkd3v
Copy link
Collaborator

jmkd3v commented Mar 8, 2021

This will not be accepted yet as it's not using our new endpoint system - the structure for building an endpoint URL should look something like this:

from ro_py.utilities.url import url
endpoint = url("users")

@nikita-petko
Copy link
Contributor Author

I probably should have reviewed the new system before I made commits

@nikita-petko
Copy link
Contributor Author

nikita-petko commented Mar 8, 2021

The test url will be removed when I make it prod worthy

endpoint = url("messagerouter.api") 
endpoint_dev = "https://messagerouter.api.sitetest4.robloxlabs.com" # Keep this here for the test api where I actually know the accessKey and X-Roblox-ChannelType

@jmkd3v
Copy link
Collaborator

jmkd3v commented Mar 8, 2021

Alright. If you have plans to add MessageRouter features, we'd prefer if those were added in this PR rather than waiting for another.

@nikita-petko
Copy link
Contributor Author

@jmkd3v The only thing that would ever be added to it is the ability to communicate with grid servers, but it will be a while until that happens, and I will probably ask you to add the changes when I find out how the grids' channel.

@jmkd3v
Copy link
Collaborator

jmkd3v commented Mar 9, 2021

Hm, I see.

@jmkd3v
Copy link
Collaborator

jmkd3v commented Apr 13, 2021

This is being closed as we move over to the rewrite branch. Feel free to redo your changes in the rewrite branch when it is ready.

@jmkd3v jmkd3v closed this Apr 13, 2021
@nikita-petko
Copy link
Contributor Author

Mbryhjkaldawad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants