Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advice for the rewrite #18

Closed
nikita-petko opened this issue May 8, 2021 · 4 comments
Closed

Advice for the rewrite #18

nikita-petko opened this issue May 8, 2021 · 4 comments

Comments

@nikita-petko
Copy link
Contributor

There is an issue with production right now, there is little to no strong typing on anything.

All implementations for the rewrite should be strong typed, as it is supported.

The benefits of this include stronger intellisense.

If you look at my libraries they show strong typed code, with predicable interfaces, it is preferable to do this because it is more convenient than having to go to some documentation page.

image
image

You can disregard this issue if you wish, but take it into mind.

@jmkd3v
Copy link
Collaborator

jmkd3v commented May 8, 2021

In the past, we have added some typing - but it was inconsistent and barely present. We plan to strongly type our code as much as possible in the rewrite.

@nikita-petko
Copy link
Contributor Author

nikita-petko commented May 9, 2021

Alright

@nikita-petko
Copy link
Contributor Author

Why wasn't the repo fully strong typed in the first place?

@nikita-petko
Copy link
Contributor Author

tee hee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants