We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
Function metrics.compute_missing_metrics has a kwarg periodic=False which is not used. Within this function a call is made to xgcm.Grid
metrics.compute_missing_metrics
periodic=False
grid = xgcm.Grid(ds, periodic=False)
Perhaps this should be
grid = xgcm.Grid(ds, periodic=periodic)
Using the kwarg from the metrics.compute_missing_metrics . Otherwise the kwarg periodic should be removed from metrics.compute_missing_metrics
periodic
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Describe the bug
Function
metrics.compute_missing_metricshas a kwargperiodic=Falsewhich is not used. Within this function a call is made to xgcm.Gridgrid = xgcm.Grid(ds, periodic=False)Perhaps this should be
grid = xgcm.Grid(ds, periodic=periodic)Using the kwarg from the
metrics.compute_missing_metrics. Otherwise the kwargperiodicshould be removed frommetrics.compute_missing_metricsThe text was updated successfully, but these errors were encountered: