Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: NEWS.md is not found by news() #13

Closed
HenrikBengtsson opened this issue Jul 7, 2018 · 3 comments
Closed

FYI: NEWS.md is not found by news() #13

HenrikBengtsson opened this issue Jul 7, 2018 · 3 comments

Comments

@HenrikBengtsson
Copy link
Contributor

HenrikBengtsson commented Jul 7, 2018

I noticed you Markdown-ified NEWS to NEWS.md. Several packages do this and CRAN parses it and renders it in HTML online. Unfortunately, it also breaks news() who will not find it, cf. HenrikBengtsson/Wishlist-for-R#40;

> news(package = "princurve")
NULL
@HenrikBengtsson
Copy link
Contributor Author

Maybe it's possible to have a copy NEWS of NEWS.md and keep both under inst/.

@rcannood
Copy link
Owner

rcannood commented Jul 7, 2018

Thanks for bringing this up.

I noticed this too, but preferred to have the news more legible on GitHub than have it work with news(). Although you're right, there's no reason why I shouldn't make both work.

What do you think about this solution? feature/improve_news (Diff). Would this be the most useful solution for both users and developers?

By the way, I really like Wishlist-for-R 👍 I wish more issues were closed, though.

@HenrikBengtsson
Copy link
Contributor Author

Thanks. I think it's important to support news() - this looks like a nice workaround.

PS. Yeah, there are a few things that can/should be fixed in that Wishlist-for-R. I'm and others are adding things there as they are discovered and eventually the issues mature and can be turned into a solid bug report/patch that R core can take quick action on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants