Clean up the missing modules error message, so it reports the actual

missing module rather than the ones it thinks it needs. Plug a security leak. You are advised to upgrade to at least this version NOW.
rcaputo · May 14, 2004 · b4294c7 · b4294c7
1 parent 1e9e5bb
commit b4294c7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/Server/Web.pm b/Server/Web.pm
@@ -139,10 +139,10 @@ sub httpd_session_got_query {
   ### Fetch some kind of data.
 
   if ($url =~ m{^/(data/.+?)\s*$}) {
-    # TODO - Better path support.
+    # TODO - Better path support?
     my $filename = $1;
-    $filename =~ s/\.\.\/\///g;
-    $filename =~ s/\/+/\//g;
+    $filename =~ s{/\.+}{/}g;  # Remove ., .., ..., etc.
+    $filename =~ s{/+}{/}g;    # Combine // into /
 
     my ($code, $type, $content);
 

diff --git a/pastebot.perl b/pastebot.perl
@@ -38,9 +38,7 @@
 sub Error ($ $) {
     my ($lib, $msg) = @_;
 
-    if ( $msg =~ "\@INC" ) {
-	 $msg = $lib;
-    }
+    $msg =~ s/ in \@INC.*//s;
 
     my $liberr = << "EOF";
 $0 Error while loading $lib: $msg
@@ -66,11 +64,10 @@ ()
     for my $lib ( @LIBS ) {
 	eval "use $lib;" ;
 
-	$@ and Error $lib, $@;
+	$@ and Error($lib, $@);
     }
 }
 
-
 LoadLibraries();
 POE::Kernel->run();
 exit 0;