Skip to content

Commit

Permalink
getnameinfo() returns host and port in the opposite order of
Browse files Browse the repository at this point in the history
unpack_sockaddr_in().  Swap the return values so the right ones appear
in ARG1 and ARG2.  Thanks to Luiz Eduardo Roncato Cordeiro at CERT
Brazil for spotting the problem and suggesting the fix.  This should
resolve his rt.cpan.org ticket, #68959.
  • Loading branch information
rcaputo committed Jul 27, 2011
1 parent 1589bc5 commit 32db4fe
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/POE/Wheel/SocketFactory.pm
Expand Up @@ -189,7 +189,7 @@ sub _define_accept_state {
}
elsif ( $domain eq DOM_INET6 ) {
$peer = getpeername($new_socket);
((my $error), $peer_port, $peer_addr) = getnameinfo($peer);
((my $error), $peer_addr, $peer_port) = getnameinfo($peer);
warn $error if $error;
}
else {
Expand Down Expand Up @@ -309,7 +309,7 @@ sub _define_connect_state {
# INET6 socket stacks tend not to.
elsif ($domain eq DOM_INET6) {
if (defined $peer) {
((my $error), $peer_port, $peer_addr) = getnameinfo($peer);
((my $error), $peer_addr, $peer_port) = getnameinfo($peer);
if ($error) {
warn $error;
$peer_port = $peer_addr = undef;
Expand Down

0 comments on commit 32db4fe

Please sign in to comment.