Skip to content

Commit

Permalink
Added RELEASE_TESTING env var checks
Browse files Browse the repository at this point in the history
Added test for 404 links in POD
Cleanup old stuff and fix MANIFEST.SKIP
  • Loading branch information
Larwan Berke committed Feb 4, 2010
1 parent 94977c1 commit 4e1ada1
Show file tree
Hide file tree
Showing 8 changed files with 47 additions and 18 deletions.
1 change: 1 addition & 0 deletions MANIFEST
Expand Up @@ -82,6 +82,7 @@ mylib/svn-log.perl
t/00_info.t
t/10_units/01_pod/01_pod.t
t/10_units/01_pod/02_pod_coverage.t
t/10_units/01_pod/03_pod_no404s.t
t/10_units/02_pipes/01_base.t
t/10_units/02_pipes/02_oneway.t
t/10_units/02_pipes/03_twoway.t
Expand Down
3 changes: 3 additions & 0 deletions MANIFEST.SKIP
Expand Up @@ -28,3 +28,6 @@ run_network_tests
test-output\.err$
t/[23]0_.*\.t
~$

# Work in Progress
^lib/POE/Loader\.pm$
6 changes: 5 additions & 1 deletion lib/POE/Filter/HTTPD.pm
Expand Up @@ -440,11 +440,15 @@ Some versions of libwww are known to generate invalid HTTP. For
example, this code (adapted from the HTTP::Request::Common
documentation) will cause an error in a POE::Filter::HTTPD daemon:
NOTE: Using this test with libwww-perl/5.834 showed that it added
the proper HTTP/1.1 data! We're not sure which version of LWP fixed
this. This example is valid for older LWP installations, beware!
use HTTP::Request::Common;
use LWP::UserAgent;
my $ua = LWP::UserAgent->new();
$ua->request(POST 'http://some/poe/driven/site', [ foo => 'bar' ]);
$ua->request(POST 'http://example.com', [ foo => 'bar' ]);
By default, HTTP::Request is HTTP version agnostic. It makes no
attempt to add an HTTP version header unless you specifically declare
Expand Down
14 changes: 0 additions & 14 deletions mylib/preprocessor.perl

This file was deleted.

5 changes: 5 additions & 0 deletions t/10_units/01_pod/01_pod.t
@@ -1,6 +1,11 @@
# vim: ts=2 sw=2 filetype=perl expandtab

use Test::More;

unless ( $ENV{RELEASE_TESTING} ) {
plan skip_all => 'enable by setting RELEASE_TESTING';
}

eval "use Test::Pod 1.00";
plan skip_all => "Test::Pod 1.00 required for testing POD" if $@;
all_pod_files_ok();
5 changes: 5 additions & 0 deletions t/10_units/01_pod/02_pod_coverage.t
Expand Up @@ -6,6 +6,11 @@
BEGIN { $^W = 0 }

use Test::More;

unless ( $ENV{RELEASE_TESTING} ) {
plan skip_all => 'enable by setting RELEASE_TESTING';
}

eval "use Test::Pod::Coverage 1.08";
plan skip_all => "Test::Pod::Coverage 1.08 required for testing POD coverage" if $@;

Expand Down
26 changes: 26 additions & 0 deletions t/10_units/01_pod/03_pod_no404s.t
@@ -0,0 +1,26 @@
#!/usr/bin/perl -w
# vim: ts=2 sw=2 filetype=perl expandtab

# Tests POD for 404 links

use strict;
use Test::More;

BEGIN {
unless (-f 'run_network_tests') {
plan skip_all => 'Need network access (and permission) for these tests';
}

unless ( $ENV{RELEASE_TESTING} ) {
plan skip_all => 'enable by setting RELEASE_TESTING';
}

foreach my $req (qw(Test::Pod::No404s)) {
eval "use $req";
if ($@) {
plan skip_all => "$req is needed for these tests.";
}
}
}

all_pod_files_ok();
5 changes: 2 additions & 3 deletions t/90_regression/rt47966-sigchld.t
Expand Up @@ -10,9 +10,8 @@ use Test::More;

sub DEBUG () { 0 }

unless ($ENV{TEST_MAINTAINER}) {
plan skip_all => 'Set TEST_MAINTAINER to run this test';
exit 0;
unless ( $ENV{RELEASE_TESTING} ) {
plan skip_all => 'enable by setting RELEASE_TESTING';
}

my $N = 60;
Expand Down

0 comments on commit 4e1ada1

Please sign in to comment.