Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing happens on any Ult* command #21

Closed
jchilders opened this issue Mar 8, 2021 · 4 comments
Closed

Nothing happens on any Ult* command #21

jchilders opened this issue Mar 8, 2021 · 4 comments
Labels
bug Something isn't working released

Comments

@jchilders
Copy link

Describe the bug
When attempting to run any of the Ult* commands, nothing happens.

Output of vim-ultest.log after running UltestNearest and then UltestAttach:

12:22:23 | INFO | MainThread | logging.py:create_logger:71 | Logger created
12:22:23 | DEBUG | MainThread | __init__.py:__init__:40 | Handler created
12:22:30 | INFO | MainThread | __init__.py:run_nearest:115 | Running nearest test in spec/models/fast_forward_spec.rb at line 139

Running tests with TestNearest from vim-test work as expected.

To Reproduce
Call :UltestNearest, etc.

Expected behavior
Tests are executed.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
This is a Ruby on Rails project. Not sure if that matters.

@jchilders jchilders added the bug Something isn't working label Mar 8, 2021
@rcarriga
Copy link
Owner

rcarriga commented Mar 8, 2021

Ah yes I see the issue, vim-ultest looks for test in a file path, which obviously isn't here. I'm not familiar with ruby, is spec standard in a test file?

@jchilders
Copy link
Author

jchilders commented Mar 8, 2021

@rcarriga For projects that use rspec -- which is every Rails project I have worked on -- yes, that directory is standard. By default, though, Rails uses the test directory. The following patterns should cover almost every case, though:

spec/**/*_spec.rb
test/**/*_test.rb

To reiterate, though: whatever TestNearest does handles this case. Perhaps UltTest* can delegate to that?

@rcarriga
Copy link
Owner

rcarriga commented Mar 8, 2021

Yep have changed it to now use vim-test to determine if the file is a test file. Unfortunately it does cause the loading of potentially quite a few scripts on startup but at least it will be consistent with vim-test

@github-actions
Copy link

github-actions bot commented Mar 8, 2021

🎉 This issue has been resolved in version 2.5.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants