Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The item is pushed down by the height of the neighboring element. #64

Closed
HazemEngMuh opened this issue Jan 24, 2018 · 9 comments
Closed
Labels

Comments

@HazemEngMuh
Copy link

When there is sides for container and we want to drag the item. It is pushed down by the height of container plus sides's height like this problem in another repository
https://drive.google.com/file/d/0B3mwXFEGAguUUkVKakZQOFpIVHc/view

@rcdexta
Copy link
Owner

rcdexta commented Jan 25, 2018

Can you explain a bit more about what do you mean by sides of the container? Can you share sample code with the container where you use the Board component, so that I can understand better..

@HazemEngMuh
Copy link
Author

HazemEngMuh commented Jan 28, 2018

      <Board
      editable
      onCardAdd={this.handleCardAdd}
      data={this.state.boardData}
      draggable
      onDataChange={this.shouldReceiveNewData}
      eventBusHandle={this.setEventBus}
      handleDragStart={handleDragStart}
      handleDragEnd={handleDragEnd}
  />

I used basic example as above. In my project I have menu on the left of screen and use plugins, Where plugins start after menu's area is finished. When I drag a card, the card's transform as the externel container I mean menu's width is calculating and increasing to card's transform(css).
It is same to this problem https://drive.google.com/file/d/0B3mwXFEGAguUUkVKakZQOFpIVHc/view

@rcdexta rcdexta added the bug label Jan 29, 2018
@rcdexta
Copy link
Owner

rcdexta commented Feb 4, 2018

v1.27.0 should address this issue. Can you please check and confirm?

@rcdexta rcdexta closed this as completed Feb 4, 2018
@HazemEngMuh
Copy link
Author

HazemEngMuh commented Feb 4, 2018

When I check it I had another errors
I don't know if I did a mistake
Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in. Check the render method of DragHandle.

:3000/static/js/bundle.js:367407 MIDDLEWARE ERROR: Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in. Check the render method of DragHandle.

Note: I use react 5

@rcdexta
Copy link
Owner

rcdexta commented Feb 4, 2018

I used some React 16 specific features. Reverted them for backward compatibility. Check v1.27.2.

@HazemEngMuh
Copy link
Author

HazemEngMuh commented Feb 4, 2018

Main bug has not been solved

@rcdexta rcdexta reopened this Feb 12, 2018
@orangecoding
Copy link
Contributor

I experienced kind of the same problem. If I drag a card around, and drop it into an empty lane, the card is first being shown at the top, outside of the lane, then transformed into the lane with a fancy move animation. Might be because I did some heavy styling around the board to match it our container style.. Need to dig deeper though..

@rcdexta
Copy link
Owner

rcdexta commented Mar 31, 2018

Release v1.28.1 has bug fixes for drag-n-drop and upgraded version of react-beautiful-dnd dependency

@rcdexta rcdexta closed this as completed Mar 31, 2018
@HazemEngMuh
Copy link
Author

Problem still exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants