-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove advisory "only once" from inbox bullet #191
Comments
Really? I don't see how to do that securely. I'm looking at the code, and it seems to involve sending my deployerId around... are we sure this is secure? I wonder in which PR this was added and how closely it was reviewed. Resting on the security of |
Yep. @jimscarver and I discussed the use of deployerId at length. I believe he's waiting for |
@dckc @jimscarver |
That might help a little, but it would be a drop in the bucket. All other dApps pose the same risk. So perhaps this should be a wallet feature. But then (and this belongs in a different issue...) what would the alert say? How would we make it intelligible to a broad audience? |
Closed by #262 |
#262 is still open; how does it address this issue? |
Now that we have MemberDirectory.rho, newinbox no longer allows multiple inbox creations. A second attempt simply returns the existing inbox. The text warning "only one" on index.html is no longer necessary.
The text was updated successfully, but these errors were encountered: