Robuster waiting for validators' readiness #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adaszko
force-pushed
the
more-robust-waiting
branch
9 times, most recently
from
3dd7cc5
to
ff9ac51
Compare
adaszko
force-pushed
the
more-robust-waiting
branch
from
ff9ac51
to
5694246
Compare
adaszko
force-pushed
the
more-robust-waiting
branch
from
a4c0e12
to
55227b6
Compare
| return 2 | ||
| fi | ||
| local container_name_substring=$1; shift | ||
| local log_message=$1; shift |
There was a problem hiding this comment.
What's the benefit of shift over $2?
There was a problem hiding this comment.
Adding and removing parameters generates fewer mistakes
| wait-for-bootstrap: | ||
| image: docker | ||
| commands: | ||
| - until ci/is-container-log-line-present.sh _step_4 'Making a transition to ApprovedBlockRecievedHandler state.'; do echo $?; sleep 5; done |
There was a problem hiding this comment.
Does drone yaml version support constants? Making a transition to ApprovedBlockRecievedHandler state. is a good candidate
There was a problem hiding this comment.
I don't believe it does
lukasz-golebiewski
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rchain.atlassian.net/browse/RCHAIN-1459