Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple "Expand details" links in upload media form #5

Closed
ATomilov opened this issue Aug 28, 2018 · 6 comments
Closed

Multiple "Expand details" links in upload media form #5

ATomilov opened this issue Aug 28, 2018 · 6 comments
Labels
bug Something isn't working

Comments

@ATomilov
Copy link
Contributor

Find some another bug )
image

@rchipka rchipka added the bug Something isn't working label Aug 28, 2018
@rchipka
Copy link
Owner

rchipka commented Aug 28, 2018

@thedonquixotic Can you reproduce this with your local setup?

@ATomilov
Copy link
Contributor Author

ATomilov commented Sep 3, 2018

@rchipka hi. Maybe it's cache or something like this? I found a bit of code where this link created in original acf plugin, but I don't sure what it's right place to looking for reasons of that bug.

@ATomilov
Copy link
Contributor Author

ATomilov commented Sep 7, 2018

@rchipka hi) I understand what actions make this bug. If you created custom block with image or gallery field (without repeater as a parent) and duplicate or create new blocks same type you get +3 links "Expand details" every time (but if you clone block in first time you get +2 links).

@ATomilov
Copy link
Contributor Author

@rchipka P.S. I found in acf-input.js what in initialization moment (maybe initialization fields group) happened append expand links but it happened without checking if links' block is exist. I can fix it in my {custom_name_file}.js in my theme, but when media upload popup is appears we see remove this link process. Duration <1 sec. but anyway it's not good solution to use it on production:-)

@rchipka
Copy link
Owner

rchipka commented Sep 14, 2018

My initial thought is that it could be related to using acf.do_action('ready') after each block render.

Do we know if the issue exists when adding multiple unique media upload fields (i.e. 2+ fields that aren't duplicated in the Gutenberg editor)?

@rchipka
Copy link
Owner

rchipka commented Oct 18, 2018

Fixed in latest version

@rchipka rchipka closed this as completed Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants