You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From some testing, I discovered that argument.getRawValue() did not function as expected if an argument spanned multiple lines but had a comment nested within said multiple lines.
RUN echo ab\
#comment
cd
Given the above Dockerfile, calling getRawValue() on the second argument would producing the following value:
ab\
#comment
cd
While it is technically correct, this result is of little value to clients as it forces clients to parse out the embedded comment themselves. Even if there was no embedded comment, getRawValue() would still return a value with the escape character and a newline character thrown inside of it.
As this library is intended to relieve clients of the need to perform any kind of parsing work, getRawValue() will be removed to make the API simpler to use. In the event that a client wishes to inspect the raw value, it can still be indirectly retrieved by first calling getRange() to get the range the argument encompasses and to then extract the string content within that range from the Dockerfile.
The text was updated successfully, but these errors were encountered:
From some testing, I discovered that
argument.getRawValue()
did not function as expected if an argument spanned multiple lines but had a comment nested within said multiple lines.Given the above Dockerfile, calling
getRawValue()
on the second argument would producing the following value:While it is technically correct, this result is of little value to clients as it forces clients to parse out the embedded comment themselves. Even if there was no embedded comment,
getRawValue()
would still return a value with the escape character and a newline character thrown inside of it.As this library is intended to relieve clients of the need to perform any kind of parsing work,
getRawValue()
will be removed to make the API simpler to use. In the event that a client wishes to inspect the raw value, it can still be indirectly retrieved by first callinggetRange()
to get the range the argument encompasses and to then extract the string content within that range from the Dockerfile.The text was updated successfully, but these errors were encountered: