Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose PropertyInstruction's getPropertyArguments() #37

Closed
rcjsuen opened this issue May 25, 2018 · 0 comments
Closed

Expose PropertyInstruction's getPropertyArguments() #37

rcjsuen opened this issue May 25, 2018 · 0 comments
Assignees

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented May 25, 2018

In c7416ab#diff-0bbbf3173979775c0d43c5237a287a4c, we changed PropertyInstruction to not override getArguments() with its own variant for the sake of consistency and changed this variant into a private function named getPropertyArguments().

As this is quite a big change and may cause problems downstream for people that expect PropertyInstruction subclasses to return more "manageable" arguments with getArguments(), we should make getPropertyArguments() public and let anyone downstream change their code to call that instead.

@rcjsuen rcjsuen self-assigned this May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant