Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create diagnostics for invalid ONBUILD triggers #117

Closed
rcjsuen opened this issue Aug 1, 2017 · 0 comments
Closed

Create diagnostics for invalid ONBUILD triggers #117

rcjsuen opened this issue Aug 1, 2017 · 0 comments
Assignees

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Aug 1, 2017

FROM, MAINTAINER, and ONBUILD instructions are not allowed to follow an ONBUILD. We should create an error diagnostic if this case is detected.

FROM scratch
ONBUILD onbuild
$ docker build .
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM scratch
 --->
Step 2/2 : ONBUILD onbuild
Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed
FROM scratch
ONBUILD maintainer
$ docker build .
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM scratch
 --->
Step 2/2 : ONBUILD maintainer
MAINTAINER isn't allowed as an ONBUILD trigger
FROM scratch
ONBUILD from
$ docker build .
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM scratch
 --->
Step 2/2 : ONBUILD from
FROM isn't allowed as an ONBUILD trigger
@rcjsuen rcjsuen closed this as completed in 301bc9c Aug 1, 2017
@rcjsuen rcjsuen self-assigned this Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant