Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create diagnostics for ENV and LABEL instructions without a name #122

Closed
rcjsuen opened this issue Aug 2, 2017 · 0 comments
Closed

Create diagnostics for ENV and LABEL instructions without a name #122

rcjsuen opened this issue Aug 2, 2017 · 0 comments
Assignees

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Aug 2, 2017

If an ENVor LABEL instruction using the name=value syntax doesn't specify a name, an error will be created by the builder. We should create a diagnostic for this same error.

FROM scratch
ENV =y
$ docker build .
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM scratch
 --->
Step 2/2 : ENV  y
ENV names can not be blank
FROM scratch
LABEL =y
$ docker build .
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM scratch
 --->
Step 2/2 : LABEL  y
LABEL names can not be blank
@rcjsuen rcjsuen self-assigned this Aug 2, 2017
@rcjsuen rcjsuen closed this as completed in 175d41c Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant