Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty lines are not being ignored and causes a comment to be interpreted as a parser directive #129

Closed
rcjsuen opened this issue Aug 4, 2017 · 0 comments
Assignees
Labels

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Aug 4, 2017

 
#escape=a
FROM alpine

According to the specification, parser directives must be at the top of the Dockerfile. However, the above Dockerfile will have its second line parsed as a parser directive and a warning will be generated about the a not being a backtick or a backslash. However, since it is on the second line and not actually at the top of the Dockerfile, it should be considered as a comment and not a parser directive and no validation diagnostics should be generated.

@rcjsuen rcjsuen added the bug label Aug 4, 2017
@rcjsuen rcjsuen self-assigned this Aug 4, 2017
@rcjsuen rcjsuen closed this as completed in b51f546 Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant