Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish diagnostic if an unknown unit of time is being used for a duration #152

Closed
rcjsuen opened this issue Aug 20, 2017 · 1 comment
Closed
Assignees

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Aug 20, 2017

The following Dockerfile will not build but no diagnostic is being published for the invalid 1s1x duration.

FROM alpine
HEALTHCHECK --interval=1s1x CMD ls
$ docker build .
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM alpine
latest: Pulling from library/alpine
88286f41530e: Pull complete
Digest: sha256:1072e499f3f655a032e88542330cf75b02e7bdf673278f701d7ba61629ee3ebe
Status: Downloaded newer image for alpine:latest
 ---> 7328f6f8b418
Step 2/2 : HEALTHCHECK --interval=1s1x CMD ls
time: unknown unit x in duration 1s1x
@rcjsuen rcjsuen added the bug label Aug 20, 2017
@rcjsuen rcjsuen self-assigned this Aug 20, 2017
@rcjsuen rcjsuen added enhancement and removed bug labels Aug 20, 2017
@rcjsuen
Copy link
Owner Author

rcjsuen commented Aug 20, 2017

Actually, just read the error message more carefully and realized that this is a completely new diagnostic that needs to be published.

@rcjsuen rcjsuen changed the title Unknown time unit used in duration not being flagged as an error Publish diagnostic if an unknown time unit is being used for a time duration Aug 20, 2017
@rcjsuen rcjsuen changed the title Publish diagnostic if an unknown time unit is being used for a time duration Publish diagnostic if an unknown unit of time is being used for a duration Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant