Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for --chown flag in ADD and COPY #166

Closed
5 tasks done
rcjsuen opened this issue Aug 28, 2017 · 3 comments
Closed
5 tasks done

Add support for --chown flag in ADD and COPY #166

rcjsuen opened this issue Aug 28, 2017 · 3 comments
Assignees
@rcjsuen
Labels
enhancement

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Aug 28, 2017 •
edited

moby/moby#34263 added support for a --chown flag to ADD and COPY instructions. We will need to support this flag in the language server when the next version of Docker CE is released.

  • suggest the flag for ADD (textDocument/completion)
  • suggest the flag for COPY (textDocument/completion)
  • implement flag validation for ADD (textDocument/publishDiagnostics)
  • publish diagnostics if the flag is misspelt or empty in a COPY (textDocument/publishDiagnostics)
  • change the signature for an ADD instruction now that it supports flags (textDocument/signatureHelp)
@rcjsuen rcjsuen mentioned this issue Oct 2, 2017
Closed
@rcjsuen rcjsuen self-assigned this Oct 2, 2017
@rcjsuen
Copy link
Owner Author

rcjsuen commented Oct 2, 2017

Docker CE 17.09 was released on 2017-09-26 so we should start getting this feature implemented.

rcjsuen added a commit that referenced this issue Oct 2, 2017
@rcjsuen
WIP #166 Validate --chown flag for ADD and COPY
51b4a78 
Signed-off-by: Remy Suen <remy.suen@gmail.com>
@rcjsuen
Copy link
Owner Author

rcjsuen commented Oct 2, 2017

Although Docker CE 17.09 has been released, the documentation for this feature has not yet been finalized as docker/cli#467 is still open.

rcjsuen added a commit that referenced this issue Oct 2, 2017
@rcjsuen
WIP #166 Validate ADD's flags spelling and values
1505c8d 
Signed-off-by: Remy Suen <remy.suen@gmail.com>
rcjsuen added a commit that referenced this issue Oct 2, 2017
@rcjsuen
WIP #166 Suggest the --chown flag for COPY
731474d 
Signed-off-by: Remy Suen <remy.suen@gmail.com>
rcjsuen added a commit that referenced this issue Oct 3, 2017
@rcjsuen
WIP #166 Suggest the --chown flag for ADD
6e1bb8a 
Signed-off-by: Remy Suen <remy.suen@gmail.com>
rcjsuen added a commit that referenced this issue Oct 3, 2017
@rcjsuen
WIP #166 Add flags to ADD's signature
1fe59aa 
As the ADD instruction now supports a new --chown flag, its signature
should be updated to state that optional flags are available for this
instruction.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@rcjsuen rcjsuen mentioned this issue Oct 3, 2017
Closed
@rcjsuen
Copy link
Owner Author

rcjsuen commented Oct 3, 2017

Closing this as the main features have all been implemented.

The documentation will be added to the language server when docker/cli#467 gets closed. #181 has been opened to track this.

@rcjsuen rcjsuen closed this as completed Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen