Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown flag's diagnostic may be of length zero #186

Closed
rcjsuen opened this issue Oct 14, 2017 · 0 comments
Closed

Unknown flag's diagnostic may be of length zero #186

rcjsuen opened this issue Oct 14, 2017 · 0 comments
Assignees
Labels

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Oct 14, 2017

FROM node
HEALTHCHECK -- CMD ls
COPY -- . .
ADD -- . .

If a flag is present but it doesn't actually have a name, a diagnostic will be created to warn about the invalid flag. However, as it has no name, the range will incorrectly be zero which can lead to conflicting behaviours in clients regarding how to highlight the error. For example, the monaco-languageclient seems to highlight the space after the range which may be confusing to the user as it is highlighting whitespace as an error.
image

@rcjsuen rcjsuen added the bug label Oct 14, 2017
@rcjsuen rcjsuen self-assigned this Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant