Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WorkspaceEdit's documentChanges if possible #202

Closed
rcjsuen opened this issue Feb 6, 2018 · 0 comments
Closed

Use WorkspaceEdit's documentChanges if possible #202

rcjsuen opened this issue Feb 6, 2018 · 0 comments
Assignees
@rcjsuen
Labels
enhancement

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Feb 6, 2018

If the client supports versioned edits, we should return a WorkspaceEdit with documentChanges to support it instead of blindly sending back changes with no context.
@rcjsuen rcjsuen closed this as completed in 329eb94 Mar 8, 2018
@rcjsuen rcjsuen self-assigned this Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen