Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the code to create a language service module #205

Closed
rcjsuen opened this issue Feb 12, 2018 · 1 comment
Closed

Refactor the code to create a language service module #205

rcjsuen opened this issue Feb 12, 2018 · 1 comment
Assignees

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Feb 12, 2018

We should create a new npm module which only includes the language services so that they can be reused in other places such as a standalone Monaco Editor. This will make it easier to embed this project in other places without having to start up a second process or necessarily support the entire language server protocol.

We created the dockerfile-utils project and moved the validator and formatter there when we implemented #79. However, I'm not sure it makes sense to move the other language services there as they're not exactly meant to be consumed by an end user on the CLI. Hence, I think a new npm module should be created instead to house the language services. We can then simply re-export the validator and formatter from dockerfile-utils there.

@rcjsuen rcjsuen changed the title Refactor the code to create a language server module Refactor the code to create a language service module Feb 14, 2018
@rcjsuen
Copy link
Owner Author

rcjsuen commented Feb 16, 2018

I've extracted the code out into the new rcjsuen/dockerfile-language-service repository. Still need to make the necessary modifications here though.

@rcjsuen rcjsuen self-assigned this Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant