Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for textDocument/prepareRename #231

Closed
rcjsuen opened this issue Aug 23, 2018 · 0 comments
Closed

Add support for textDocument/prepareRename #231

rcjsuen opened this issue Aug 23, 2018 · 0 comments
Assignees
@rcjsuen
Labels
enhancement

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Aug 23, 2018

LSP v3.12.0 has added a new request named textDocument/prepareRename (see microsoft/language-server-protocol#455). We should implement this to prevent people from renaming random things in a Dockerfile.

The only things that we should allow people to rename are:

  • variable names
  • build stage names
@rcjsuen rcjsuen self-assigned this Aug 23, 2018
rcjsuen added a commit that referenced this issue Dec 30, 2018
@rcjsuen
Fix #231 Update README.md with prepare rename support
9afbc93 
Signed-off-by: Remy Suen <remy.suen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen