Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a diagnostic if a duplicate instruction flag has been specified #83

Closed
rcjsuen opened this issue Jul 18, 2017 · 0 comments
Closed
Assignees

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Jul 18, 2017

The following two Dockerfiles will not build.

FROM scratch
HEALTHCHECK --interval=10 --interval=10 CMD ls	
$ docker build .
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM scratch
 --->
Step 2/2 : HEALTHCHECK --interval=10 --interval=10 CMD ls
Duplicate flag specified: interval
FROM scratch AS setup
COPY --from=setup --from=setup . .
$ docker build .
Sending build context to Docker daemon   59.6MB
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM scratch AS setup
 --->
Step 2/2 : COPY --from=setup --from=setup . .
Duplicate flag specified: from

The following Dockerfile will build as the engine does not validate flags for a HEALTHCHECK NONE instruction.

FROM scratch
HEALTHCHECK --interval=10 --interval=10 NONE
$ docker build .
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM scratch
 --->
Step 2/2 : HEALTHCHECK --interval=10 --interval=10 NONE
 ---> Running in f3e084086096
 ---> f5df294db6b4
Removing intermediate container f3e084086096
Successfully built f5df294db6b4
@rcjsuen rcjsuen self-assigned this Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant