Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a diagnostic if HEALTHCHECK's interval, start-period, or timeout flag does not specify its unit of time #86

Closed
rcjsuen opened this issue Jul 18, 2017 · 0 comments
Closed

Create a diagnostic if HEALTHCHECK's interval, start-period, or timeout flag does not specify its unit of time #86

rcjsuen opened this issue Jul 18, 2017 · 0 comments
Assignees
@rcjsuen
Labels
enhancement

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Jul 18, 2017

If the duration for an interval, start-period, or timeout flag of a `HEALTHCHECK doesn't specify the unit of time, the engine will throw an error. We should do the same.

FROM scratch AS setup
HEALTHCHECK --interval=10 CMD ls
$ docker build .
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM scratch AS setup
 --->
Step 2/2 : HEALTHCHECK --interval=10 CMD ls
time: missing unit in duration 10
rcjsuen added a commit that referenced this issue Jul 25, 2017
@rcjsuen
Fix #86 Correct the name of a test
f9011f5 
Signed-off-by: Remy Suen <remy.suen@gmail.com>
@rcjsuen rcjsuen assigned rcjsuen and unassigned rcjsuen Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen