Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a diagnostic if HEALTHCHECK's interval, start-period, and timeout flags are invalid #87

Closed
rcjsuen opened this issue Jul 18, 2017 · 0 comments
Assignees

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Jul 18, 2017

If you try to enter in characters for the interval, start-period, or timeout flag of a HEALTHCHECK instruction, the engine will throw an error. We should do the same and create a diagnostic for this case.

FROM scratch AS setup
HEALTHCHECK --start-period=a CMD ls
$ docker build .
Sending build context to Docker daemon  86.15MB
Step 1/2 : FROM scratch AS setup
 --->
Step 2/2 : HEALTHCHECK --start-period=a CMD ls
time: invalid duration a
@rcjsuen rcjsuen self-assigned this Jul 25, 2017
@rcjsuen rcjsuen changed the title Create a diagnostic if HEALTHCHECK's interval, start-period, and timeout flags is invalid Create a diagnostic if HEALTHCHECK's interval, start-period, and timeout flags are invalid Jul 25, 2017
@rcjsuen rcjsuen assigned rcjsuen and unassigned rcjsuen Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant