Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the document symbols code to create an AST #24

Closed
rcjsuen opened this issue Jun 27, 2017 · 0 comments
Closed

Rewrite the document symbols code to create an AST #24

rcjsuen opened this issue Jun 27, 2017 · 0 comments
Assignees

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Jun 27, 2017

At the moment, every response handler parses a Dockerfile with its own unique code. While a Dockerfile's syntax is not exactly very complicated, a lot of code that is very similar is replicated across the entire codebase. We should rewrite a parser from scratch that will create an AST of sorts that knows where a comment, directive, and instruction line starts and ends (including any escaped newlines in the case of instructions).

To validate that this parser is working as intended, it will first be used to replace dockerSymbols.ts before further refactorings across the entire codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant