Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct link range calculation if tag provided with a digest #120

Closed
rcjsuen opened this issue Sep 10, 2023 · 0 comments
Closed

Correct link range calculation if tag provided with a digest #120

rcjsuen opened this issue Sep 10, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Sep 10, 2023

This is reproducible on 0.10.0 but was fixed in 0.11.0. We should still add a test for this though.


0.10.0:

const lib = require("dockerfile-language-service@0.10.0");
const service = lib.DockerfileLanguageServiceFactory.createLanguageService();
const links = service.computeLinks("FROM microsoft/dotnet:non-existent-tag@sha256:5483e2b609c0f66c3ebd96666de7b0a74537613b43565879ecb0d0a73e845d7d");
console.log(links[0].data);
_/dotnet:non-existent-tag/

0.11.0:

const lib = require("dockerfile-language-service@0.10.0");
const service = lib.DockerfileLanguageServiceFactory.createLanguageService();
const links = service.computeLinks("FROM microsoft/dotnet:non-existent-tag@sha256:5483e2b609c0f66c3ebd96666de7b0a74537613b43565879ecb0d0a73e845d7d");
console.log(links[0].data);
r/microsoft/dotnet/
@rcjsuen rcjsuen added the bug Something isn't working label Sep 10, 2023
@rcjsuen rcjsuen self-assigned this Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant