Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content that comes after a JSON's closing bracket should be ignored #33

Closed
rcjsuen opened this issue Apr 3, 2018 · 0 comments
Closed
Assignees
Labels

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Apr 3, 2018

The following Dockerfile can be built by Docker but the validator will flag it with an error because of the extra argument after the closing bracket.

FROM alpine
SHELL [ "bin/sh" ] ]
$ dockerfile-utils lint Dockerfile
Line: 2
SHELL [ "bin/sh" ] ]
      ^^^^^^^^^^^^^^
Error: SHELL requires the arguments to be in JSON form
$ docker build .
Sending build context to Docker daemon  1.695MB
Step 1/2 : FROM alpine
 ---> 3fd9065eaf02
Step 2/2 : SHELL [ "bin/sh" ] ]
 ---> Running in b0da3c65034a
Removing intermediate container b0da3c65034a
 ---> aa065d62e762
Successfully built aa065d62e762
@rcjsuen rcjsuen added the bug label Apr 3, 2018
@rcjsuen rcjsuen self-assigned this Apr 3, 2018
@rcjsuen rcjsuen closed this as completed in 295e7ab Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant