Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag quoted arguments in ARG, ENV, and LABEL as an error #40

Closed
rcjsuen opened this issue May 22, 2018 · 1 comment
Closed

Flag quoted arguments in ARG, ENV, and LABEL as an error #40

rcjsuen opened this issue May 22, 2018 · 1 comment
Assignees

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented May 22, 2018

The following two Dockerfiles will pass the validator just fine.

FROM scratch
ENV "a.b.c=xyz"
FROM scratch
ENV "a.b.c=xyz

However, Docker will refuse to build it. If possible, we should try to detect this case and flag an error as well.

$ docker build .
Sending build context to Docker daemon  1.693MB
Step 1/2 : FROM scratch
 --->
Step 2/2 : ENV "a.b.c=xyz"
failed to process "\"a.b.c": unexpected end of statement while looking for matching double-quote
$ docker build .
Sending build context to Docker daemon  1.693MB
Step 1/2 : FROM scratch
 --->
Step 2/2 : ENV "a.b.c=xyz
failed to process "\"a.b.c": unexpected end of statement while looking for matching double-quote
@rcjsuen rcjsuen changed the title Flag quoted arguments in ENV as an error Flag quoted arguments in ARG, ENV, and LABEL as an error May 23, 2018
@rcjsuen
Copy link
Owner Author

rcjsuen commented May 23, 2018

These are also invalid for ARG and LABEL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant