Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in filter warning errors #4741

Open
edwardxml opened this issue Nov 5, 2020 · 0 comments
Open

Inconsistency in filter warning errors #4741

edwardxml opened this issue Nov 5, 2020 · 0 comments

Comments

@edwardxml
Copy link
Contributor

edwardxml commented Nov 5, 2020

What is your current rclone version (output from rclone version)?

1.53.2 Ubuntu ARM64

What problem are you are trying to solve?

The potential conflict arising from mixing --include... and --exclude... filter options in a command line is properly trapped with an error message. The same issue arises mixing --filter... options with either of the earlier option families but no error message is created.

https://forum.rclone.org/t/implied-include-filter/20217/5

The conflict 'error' message is currently sent to std error but the return from the command remains zero.

How do you think rclone should be changed to solve that?

Consider a more consistent approach to presenting the error message and whether or not the return value should change.

My reservations - breaking backwards compatibility in the installed base.

Edit 1 - altered to remove refs to --files-from... Filters are disabled with it and proper error message in place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants