Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSI windows package #5409

Open
trashcluster opened this issue Jun 14, 2021 · 14 comments
Open

MSI windows package #5409

trashcluster opened this issue Jun 14, 2021 · 14 comments

Comments

@trashcluster
Copy link

What problem are you are trying to solve?

Rclone would greatly benefit from an official .msi package on its release page.
Could be deployed on windows enterprise environment and used to create a winget manifest

How do you think rclone should be changed to solve that?

Create a MSI installer package

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.
@ncw
Copy link
Member

ncw commented Jun 18, 2021

If someone was to do this work so it worked in GitHub actions (it runs on a Windows VM) then I would certainly merge it.

I'm not going to attempt it though since I'm not very good at Windows and have made too many really bad Windows installers in the past ;-)

@ncw ncw added this to the Help Wanted milestone Jun 18, 2021
@hahanonym
Copy link

hahanonym commented Jul 5, 2021

hey,you can use NSIS to create a windows installer (*.exe) .this is very easy
https://github.com/NSIS-Dev/github-action-examples/blob/master/.github/workflows/windows-latest.yml
image

mycreate.nsi file like that
image

@ncw
Copy link
Member

ncw commented Jul 5, 2021

Do you want to send a PR @hahanonym

@BraINstinct0
Copy link

Currently considering two options; Maybe will PR both if I have time (not now).

  1. Self-extracting 7z EXE
  2. NSIS method suggested by @hahanonym

Which seems like a better option?

@ncw
Copy link
Member

ncw commented Sep 4, 2021

NSIS makes a somewhat normal Windows installer, so I'd probably go for that.

@BraINstinct0
Copy link

Update: currently have little time to write/test winget-supported installer.
Anyone possible should just PR without regards to this.

Currently considering two options; Maybe will PR both if I have time (not now).

  1. Self-extracting 7z EXE
  2. NSIS method suggested by @hahanonym

Which seems like a better option?

@BraINstinct0
Copy link

I don't think I can PR for the whole Build process addition; It seems like too much for me now.
Would prefer someone else to be assigned to this;
as a side note,the simple .nsi idea by @hahanonym does work, but I do not know how to integrate it well into the build process.

@ncw
Copy link
Member

ncw commented Sep 20, 2021

If you can make a script to do the build, I can integrate it into the build process...

@BraINstinct0 BraINstinct0 removed their assignment Sep 29, 2021
@BraINstinct0
Copy link

BraINstinct0 commented Sep 29, 2021

Could not get it working correctly. De-assigning.

@ivandeex
Copy link
Member

ivandeex commented Nov 3, 2021

@hahanonym
Copy link

I don‘t try this solution in my work during use rclone。
I just use nssm build a win service ,then it can be work fine。
If some one need ui installer,maybe he can use nsis and nssm both

@thekovie
Copy link

and used to create a winget manifest

@sitiom
Copy link
Contributor

sitiom commented Mar 7, 2023

and used to create a winget manifest

Thanks! I have created a PR to add the Winget Releaser workflow to keep it up-to-date:

@jcasale
Copy link

jcasale commented May 31, 2023

@ncw I'd love to archive my repository in lieu of you incorporating my packaging at jcasale/rclone-msi.

This is a dead simple msi to produce and offers many advantages over the executable-based installers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants