check that bug introduced in go 1.21.4 is fixed in go 1.21.5

[rcRsc2]

Since rclone 1.6.5 local folders aren't (always) read correctly, (see thread at rclone forum), supposedly a bug introduced in go 1.21.4.

As requested by @ncw this issue is a reminder to check that go 1.21.5 fixed this.

[ncw]

go1.21.5 was just released...

I sent off a build but it is still on 1.21.4 on GitHub actions. I'll try again tomorrow.

[albertony]

I tested it locally with 1.21.5, and it seems the issue is fixed now.

Fired off a new build on github, but still 1.21.4, and then I remembered to check https://github.com/actions/go-versions where it needs to be added to https://github.com/actions/go-versions/blob/main/versions-manifest.json first, which usually takes some hours (or a day).

[ncw]

@albertony do we still need acf1e2d and 65987f5 (not sure if that is the right commit) with go1.21.5?

[albertony]

I quickly tested revert acf1e2d, and then go test in lib\file: PASS. I assume that was what was failing before (go < 1.21.5 and withou this commit)?

[ncw]

Yes, thats right. There are comments in lib/file/mkdir_windows_test.go showing which tests broke under 1.21.4.

Do you think we should revert that commit? I guess it isn't that important if it works with go1.21.5 also.

[albertony]

The versions-manifest.json has been updated now, so I triggered a new build which I confirmed is with go1.21.5.

@rcRsc2 you may try out latest beta.

Do you think we should revert that commit?

Maybe. I will think, and do some testing..

[rcRsc2]

@rcRsc2 you may try out latest beta.

Thank you, this version works flawless for rclone lsf C:\ -vv on my system.

[nahid6970]

rclone ls d:\ or rclone ncdu d:\ still not working

[albertony]

And you are running the beta? Can you show output from rclone version please.

[nahid6970]

And you are running the beta? Can you show output from rclone version please.

no . i am using the stable version. i once had some major issue with beta version which deleted all my files and i dont know why it was a long time ago. So this fix wont come to main version?

[rcRsc2]

SMH
Your demanding (this is a freeware!) approach creates unnecessary friction (support effort) that only slows down development.
The fix will eventually come to the full version. For now 1.64.2 works as flawless (as before the 1.65 bug) so just stick with it until the next version is available.

[ncw]

This will come to 1.65.1 which will be released as soon as I can resolve one last problem!

[nahid6970]

SMH
Your demanding (this is a freeware!) approach creates unnecessary friction (support effort) that only slows down development.
The fix will eventually come to the full version. For now 1.64.2 works as flawless (as before the 1.65 bug) so just stick with it until the next version is available.

i am literally demanding nothing !! i just asked a simple question. but it seemed instead of answering it or ignoring it u got angry for no reason. if its too hard for u to answer that just ignore my message. i am literally not asking the dev to fix it

[albertony]

Do you think we should revert that commit? I guess it isn't that important if it works with go1.21.5 also.

To follow up @ncw on this one; as far as I can tell, after reading code and manually testing different variants of the code, the commit acf1e2d now has no effect at all. So, as you say, its probably not important what we do with it. My suggestion is still that we remove the added condition, for the only reason that it reduces the complexity a little when reading and reasoning around the code.