Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #21

Closed
6 tasks done
micwoj92 opened this issue Jun 25, 2021 · 5 comments
Closed
6 tasks done

Improve CI #21

micwoj92 opened this issue Jun 25, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed internal use Opened by RCMaehl or other contributor

Comments

@micwoj92
Copy link
Collaborator

micwoj92 commented Jun 25, 2021

I think that the CI is pretty bad, I have been working a bit on improving it but I don't know Windows/Powershell that much and I hope that due to this project's popularity someone who knows better will see it.
So couple of points I think are worth improving:

  • Use more (GitHub provided) variables so the CI is more flexible (example ${{ github.repository }} which is used now)

  • Change manual git clone to actions/checkout (it's pretty easy, but for some reason not always as reliable)

  • Change manual autoit download+install to use some package manager (or just a faster/better/more elegant way, I tried chocolatey and it worked but was very slow, scoop worked much better, but with pretty small size of autoit tools and the fact that first you need to get scoop itself I don't know if it brings any time benefits)
    ^ Caching is used now

  • Remove the ugly (in my opinion) need for Start-Sleep -s 10. This is "because it returns back to shell before it completes". and by "it" I mean the autoit compiler/tools. I tried different methods, for example loop that checks if file exists but it either hanged the GitHub runner or was really slow (and still needed wait command anyway). Again, I might be missing something obvious here.

  • Print hash of produced binary (and then use it in release)

  • Automatically upload artifacts on release.

@rcmaehl rcmaehl added enhancement New feature or request help wanted Extra attention is needed labels Jun 25, 2021
@sanny-io
Copy link

Linking this related comment here.

#20 (comment)

@micwoj92
Copy link
Collaborator Author

Ok, this should be easy (besides that automation part) but it is up to Robert to change his workflow. Thanks for suggestion.

@micwoj92
Copy link
Collaborator Author

@rcmaehl Will next release be artifact from CI? Then it would solve 1st point.

@rcmaehl
Copy link
Owner

rcmaehl commented Jun 26, 2021

@rcmaehl Will next release be artifact from CI? Then it would solve 1st point.

I mean.... It can be.

@micwoj92
Copy link
Collaborator Author

Thanks, then it also needs to include new x86 build + hashes for it.

@rcmaehl rcmaehl added the internal use Opened by RCMaehl or other contributor label Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed internal use Opened by RCMaehl or other contributor
Projects
None yet
Development

No branches or pull requests

3 participants