Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer builds on non-x86/arm architectures #124

Closed
q66 opened this issue Aug 31, 2020 · 5 comments · Fixed by #125
Closed

no longer builds on non-x86/arm architectures #124

q66 opened this issue Aug 31, 2020 · 5 comments · Fixed by #125

Comments

@q66
Copy link

q66 commented Aug 31, 2020

since switching to rustls, this will no longer build on any architectures other than x86 and arm, since ring is not portable

@rcoh
Copy link
Owner

rcoh commented Aug 31, 2020

indeed. Do you need self-update functionality? I can make that a feature so you can opt out of it.

@q66
Copy link
Author

q66 commented Aug 31, 2020

i don't really need anything, i noticed builds in our distro failed after some recent updates - why not just make openssl into a feature? (in a distro this will link against system openssl, which is preferrable)

@q66
Copy link
Author

q66 commented Aug 31, 2020

that said, just disabling self-update would probably be okay too, since installing from a distro means it'll be managed via the package manager, and self-updates sound like they'd interfere with that

@rcoh
Copy link
Owner

rcoh commented Aug 31, 2020

yeah sorry, my build infrastructure dropped SSL support so I had to switch to rustls. Can take care of this in a few days (or I would accept a PR)

@q66
Copy link
Author

q66 commented Aug 31, 2020

i can manually patch it to use openssl again on our side, and drop the patch once it's fixed here (likely via self-update disable, as that just makes more sense for us)

just wanted to open an issue so we don't have to hold onto custom patches indefinitely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants