squid:S1854 - Dead stores should be removed

rcongiu · Feb 11, 2016 · e2f20ac · e2f20ac
1 parent 604b3bd
commit e2f20ac
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 13 deletions.
diff --git a/...de/src/main/java/org/openx/data/jsonserde/objectinspector/JsonObjectInspectorFactory.java b/...de/src/main/java/org/openx/data/jsonserde/objectinspector/JsonObjectInspectorFactory.java
@@ -82,8 +82,6 @@ public static ObjectInspector getJsonObjectInspectorFromTypeInfo(
                     break;
                 }
                 case UNION:{
-                    UnionTypeInfo unionTypeInfo = (UnionTypeInfo) typeInfo;
-
                     List<ObjectInspector> ois = new LinkedList<ObjectInspector>();
                     for(  TypeInfo ti : ((UnionTypeInfo) typeInfo).getAllUnionObjectTypeInfos()) {
                         ois.add(getJsonObjectInspectorFromTypeInfo(ti, options));

diff --git a/json/src/main/java/org/openx/data/jsonserde/json/JSONML.java b/json/src/main/java/org/openx/data/jsonserde/json/JSONML.java
@@ -49,12 +49,12 @@ private static Object parse(XMLTokener x, boolean arrayForm,
     		JSONArray ja) throws JSONException {
         String     attribute;
         char       c;
-        String	   closeTag = null;
+        String	   closeTag;
         int        i;
-        JSONArray  newja = null;
-        JSONObject newjo = null;
+        JSONArray  newja;
+        JSONObject newjo;
         Object     token;
-        String	   tagName = null;
+        String	   tagName;
 
 // Test for and skip past these forms:
 //      <!-- ... -->
@@ -202,7 +202,6 @@ private static Object parse(XMLTokener x, boolean arrayForm,
 		                		throw x.syntaxError("Mismatched '" + tagName + 
 		                				"' and '" + closeTag + "'");
 					        }
-		                	tagName = null;
 		            		if (!arrayForm && newja.length() > 0) {
 		            			newjo.put("childNodes", newja);
 		            		}

diff --git a/json/src/main/java/org/openx/data/jsonserde/json/XML.java b/json/src/main/java/org/openx/data/jsonserde/json/XML.java
@@ -131,7 +131,7 @@ private static boolean parse(XMLTokener x, JSONObject context,
                                  String name) throws JSONException {
         char       c;
         int        i;
-        JSONObject jsonobject = null;
+        JSONObject jsonobject;
         String     string;
         String     tagName;
         Object     token;
@@ -421,11 +421,6 @@ public static String toString(Object object, String tagName)
                 if (value == null) {
                 	value = "";
                 }
-                if (value instanceof String) {
-                    string = (String)value;
-                } else {
-                    string = null;
-                }
 
 // Emit content in body