Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain that require(S7) will cause R CMD Check WARNING & NOTE #326

Closed
jonthegeek opened this issue Aug 27, 2023 · 0 comments · Fixed by #349
Closed

Explain that require(S7) will cause R CMD Check WARNING & NOTE #326

jonthegeek opened this issue Aug 27, 2023 · 0 comments · Fixed by #349

Comments

@jonthegeek
Copy link
Contributor

https://github.com/RConsortium/OOP-WG/blob/965ab8ff1da9a599d494ed10dee033fa27a99e4c/vignettes/packages.Rmd#L77

The wording here seems a bit too gentle. It generates a WARNING and a NOTE in R CMD Check (rightly), which might be more than users expect.

* checking dependencies in R code ... WARNING
Warning: 'library' or 'require' call not declared from: ‘S7’
'library' or 'require' call to ‘S7’ in package code.
  Please use :: or requireNamespace() instead.
  See section 'Suggested packages' in the 'Writing R Extensions' manual.
* checking R code for possible problems ... NOTE
File ‘rapid/R/zzz.R’:
  .onAttach calls:
    require(S7)
Package startup functions should not change the search path.
See section ‘Good practice’ in '?.onAttach'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants