Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tilde for dependency versions #59

Merged
merged 2 commits into from Jan 29, 2021
Merged

Use tilde for dependency versions #59

merged 2 commits into from Jan 29, 2021

Conversation

rushsteve1
Copy link
Contributor

Remove all patch numbers in dependency package versions and add the ~ tilde operator prefix to the front. This limits all packages to the compatibility range (just the patch).

This should reduce dependabot alerts, and make the ones that opened more meaningful instead of just patch bumps.

Cargo.lock updated to match

Remove all patch numbers in dependency package versions and add the ~
tilde operator prefix to the front. This limits all packages to the
compatibility range (just the patch).

This should reduce dependabot alerts, and make the ones that opened
more meaningful instead of just patch bumps.

Cargo.lock updated to match
@vcfxb
Copy link
Member

vcfxb commented Jan 29, 2021

I think this is a good idea. The only concern that I have is that juniper (the graphql library) has (perhaps unintentionally) released breaking changes in a patch version. If they do this again and we aren't locked into the specific patch that works, it will cause issues. I think other than juniper, I'm ready to merge this.

@rushsteve1
Copy link
Contributor Author

Well Juniper ties into the #58 discussion too, so it might not be an issue depending on how that goes.

@vcfxb
Copy link
Member

vcfxb commented Jan 29, 2021

After the discussion on #58 I think this should be fine to merge as soon as #60 merges and this one's checks finish. Hopefully there will be no conflicts.

@vcfxb vcfxb merged commit 84cff82 into rcos:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants