Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter Object and Adaptation #16

Closed
LeahPrice opened this issue Aug 4, 2017 · 3 comments
Closed

Parameter Object and Adaptation #16

LeahPrice opened this issue Aug 4, 2017 · 3 comments

Comments

@LeahPrice
Copy link
Collaborator

@LeahPrice LeahPrice commented Aug 4, 2017

The next couple of planned pull requests are about making it easier to keep track of and adapt additional algorithm parameters. This is useful in general and it is especially important when using SMC to perform inference on static Bayesian models. In this pull request, I'd like to make the necessary changes to the existing library:

  • Adding a template parameter for the algorithm parameters to the sampler object
  • Creating a base class for adaptation

My plan is to give the examples in a separate pull request.

@adamjohansen
Copy link
Collaborator

@adamjohansen adamjohansen commented Aug 4, 2017

This seems sensible to me.

If I interpret this correctly, the additional template parameter will break backward compatibility; that should be clearly signposted in the associated docs.

@LeahPrice
Copy link
Collaborator Author

@LeahPrice LeahPrice commented Aug 4, 2017

I've set it up so that there is a empty class as the default template parameter, so fortunately it shouldn't break backwards compatibility.

@adamjohansen
Copy link
Collaborator

@adamjohansen adamjohansen commented Aug 4, 2017

Oh, great -- I'd forgotten where we'd ended up after all those discussions. I should have checked...

@LeahPrice LeahPrice closed this Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.