Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme has inconsistent padding compared to light theme #6

Closed
PicoPlanetDev opened this issue Sep 20, 2021 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@PicoPlanetDev
Copy link

LightDarkDiscrepancy

If you look closely at the titlebar in my demo window, the "b" becomes slightly more cut off than in light theme after the theme switches to dark. It appears to be affecting both the horizontal and vertical padding/margin, because more complex windows with vertically stacked items also results in the labels pushing the rest of the content down. Here is an example from another project I am working on:
SizingIssueLightDark

I have skimmed through the light and dark tcl themes but haven't found anything that might cause this.

@rdbende
Copy link
Owner

rdbende commented Sep 20, 2021

I can't find anything, that might cause this issue, so I think, it's an issue with ttk itself. Also, if you have treeview in your GUI, the resizing is more radical.

@PicoPlanetDev
Copy link
Author

Thank you for checking on this. I do not have a treeview anywhere, it looks like it is just the label widgets themselves. I will experiment with manually setting padding and see if I can come up with anything else that may help reproduce this issue.

@rdbende
Copy link
Owner

rdbende commented Dec 23, 2021

Strange, but I can't find anything related to it.

simplescreenrecorder-2021-12-23_11.35.18.mp4

@rdbende
Copy link
Owner

rdbende commented Dec 23, 2021

Ahh, found

-borderwidth 1 \

vs
-borderwidth 0 \

I put it there, because I needed a 1px border for the Combobox dropdown, in the meantime I realized that there is a ComboboxPopdownFrame, but I forgot to change this back to 0.

@rdbende rdbende unpinned this issue Dec 23, 2021
@PicoPlanetDev
Copy link
Author

Oops, that would explain it! Thank you so much, I will update my applications that make use of this awesome theme.

@rdbende rdbende added the bug Something isn't working label Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants