Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give proper names to APIs, types, etc #55

Closed
rdbo opened this issue Dec 24, 2022 · 1 comment
Closed

Give proper names to APIs, types, etc #55

rdbo opened this issue Dec 24, 2022 · 1 comment

Comments

@rdbo
Copy link
Owner

rdbo commented Dec 24, 2022

Some things in libmem are not properly named. For example, LM_GetProcessIdEx. It should be something like LM_FindProcessId, since it has no guarantee that it will be got or not - on the other side LM_GetProcessId is always going to succeed by returning the current process ID.
@rdbo
Copy link
Owner Author

rdbo commented Dec 30, 2022

Done: from bcf45d6 to 773cc36

@rdbo rdbo closed this as completed Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rdbo