Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to RDS expects that password are available before connect #127

Closed
hean01-cendio opened this issue Jul 7, 2017 · 6 comments
Closed

Comments

@hean01-cendio
Copy link
Contributor

hean01-cendio commented Jul 7, 2017

We could solve this with several mechanisms the following two comes to mind:

  1. Prompt for password input via stdin if no password is supplied via command line arguments
  2. Use an askpass mechanism eg. such as from ssh:
SSH_ASKPASS    If ssh needs a passphrase, it will read the passphrase from the 
               current terminal if it was run from a terminal.  If ssh does not
               have a terminal associated with it but DISPLAY and SSH_ASKPASS 
               are set, it will execute the program specified by SSH_ASKPASS 
               and open an X11 window to read the passphrase. This is particularly
               useful when calling ssh from a .xsession or related script.  
               (Note that on some machines it may be necessary to redirect the 
               input from /dev/null to make this work.)
@hean01-cendio
Copy link
Contributor Author

This is a potential solution for issue #8 with double login prompts while connecting to session broker and gets redirected.

@hean01-cendio
Copy link
Contributor Author

We should also decide on pull request #116, eg. providing password through environment.

@hean01-cendio
Copy link
Contributor Author

The idea is to check whenever SSH_ASKPASS is available for use, if NOT fallback to internal code that provides a prompt to console and reads the password from stdin.

@trentasis
Copy link

Anybody can describe how to use, for example an example hot to test with latest master branch... if this is available...

This can help many people!
Thanks

@hean01-cendio
Copy link
Contributor Author

@trentasis These are ideas and are not yet implemented

@hean01-cendio hean01-cendio added this to the rdesktop-1.8.4 milestone Aug 14, 2017
@hean01-cendio
Copy link
Contributor Author

Commit 1aaafc8 changes the behavior of rdesktop to always prompt for a password if not provided. This is the first obviously change. SSH_ASKPASS is questionable due to it requires infrastructure for it to work. such ass ssh-gnome-askpass and environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants